-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spikes: Element Ids, Clear actions #116
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 86d5917 and detected 11 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 30.5% (90% is the threshold). This pull request will bring the total coverage in the repository to 90.4% (-3.5% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of good changes in this PR, the only thing that concerns me is the cmitId but I don't think there will be an issue with merging that in atm. This will cause merge conflicts with my pr 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm glad it was this easy to edit this schema!!!
Description
Apologies in advance, this has very much been an exercise in yak shaving. Set out to just get clear functionality working and kept brushing up against other issues or requirements to do so.
This PR:
Gotchas:
Related ticket(s)
CMDCT-4241, CMDCT-4169
How to test
Important updates
Author checklist
convert to a different template: test → val | val → prod